Please read a few of the recent posts on the subject of new or upgrade controllers.
It’s a pity that somebody has planted the thought in your mind that there is such a thing as the “Real McCoy” and even more so that it would be the latest entry, Pioneer’s RekordBox DJ (which I assume you mean as RB itself is just glorified track management and not DJ software).
There is NO BEST DJ Software. It is that simple. There is only the best DJ software for YOU!
And that is based on your current and/or desired workflow. So if Traktor is the software that most closely matches your workflow and you have the controller that fits your workflow, software and budget, then you are all set. Even a move to the S8 is something I’d only undertake if my workflow included very heavy Stems use for example and my workflow could do without jogwheels (both negative for me personally).
Switching software WILL have you redoing beat grids, cue points and other Traktor specific things you might have done.
Unless you have a very good reason to move (other than the totally misguided “RB DJ is the real McCoy” notion), I’d stick with what you’ve got. With Traktor really only shining with NI gear attached, there isn’t too much room to upgrade other than the S5/S8 route, where you have to real check your workflow to even consider the S5 an upgrade to your S4.